Re-raise encountered exceptions in pilot tests #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pilot-exceptions
|
To keep in mind for when this PR settles and/or is ready to merge: the fix that's in here for So when this lands we need to be 100% sure that it doesn't reintroduce #2557 and if it does (I suspect it might actually), thanks to #2582 being fixed, we can likely actually fix #2557 using the rebuild in |
|
I've confirmed that this doesn't break |
willmcgugan
reviewed
Jun 12, 2023
willmcgugan
approved these changes
Jun 12, 2023
rodrigogiraoserrao
added a commit
that referenced
this pull request
Mar 25, 2024
This is probably an edge-case that wasn't covered in the original PR that introduced the machinery (namely App._exception and App._exception_event) that I want to leverage here. Related PRs: #2754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception was raised in a pilot test, it prevented logic in
_wait_for_screenfrom working correctly (counters would never decrement to zero). The result was that when exceptions occurred, it always timed out.We now record the first exception that occurs in an app, and we re-raise that exception in the
__aexit__of the context manager returned byrun_test, so that tests fail and test frameworks will print the stack trace.We now detect if an exception occurs and set an event. If the event is set, then
_wait_for_screenwon't wait for the timeout to be reached allowing it to exit early.